-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Remove deprecated beta10 apis #5168
Conversation
b7b7599
to
865fe51
Compare
The CI will be made green via #5169 (could probably be merged first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got nothin' but nitpicks :) And aside from the remaining linting issue, that's a 👍 from me.
I also did an E2E UI test run locally and it looks 👌
@@ -46,7 +46,7 @@ prototype(Neos.Neos:View.Login) < prototype(Neos.Fusion:Component) { | |||
</figure> | |||
|
|||
<h1 class="neos-login-heading"> | |||
{I18n.id('login.index.title').value('Login to').package('Neos.Neos').source('Main')} <strong>{site.name}</strong> | |||
{I18n.id('login.index.title').value('Login to').package('Neos.Neos').source('Main')} <strong>{props.site.name.value}</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php
Outdated
Show resolved
Hide resolved
865fe51
to
9120075
Compare
9120075
to
32c2a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are green again (thx @kitsunet), this looks very mergeable to me
Nod yeah post merge 👍 |
Resolves: #5043
CommandResult::block()
Node::$nodeName
Node::$nodeAggregateId
Node::getLabel()
Node::$subgraphIdentity
NodeAggregate::$contentStreamId
Node::$nodeType
was already removed previously via !!! TASK: RemoveNode::nodeType
#5021Upgrade instructions
See release notes of Beta10: https://discuss.neos.io/t/neos-9-beta-10-release/6578
Review instructions
The last usage of
$node->subgraphIdentity->contentStreamId
in the CI will be removed here #5169 and will turn the tests green.Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions